search

apa512 / clj-rethinkdb

Eclipse Public License 1.0
205 stars 42 forks source link

Any reason not to use protobuf-java 3.0.2? #189

Open jwr opened 6 years ago

jwr commented 6 years ago

The current release of clj-rethinkdb (0.15.26) depends on an alpha version of protobuf-java. This clashes with ClojureScript 1.9.854, which will not compile with this version. Adding an exclusion:

[com.apa512/rethinkdb "0.15.26" :exclusions [com.google.protobuf/protobuf-java]]

fixes the problem.

Are there reasons not to use protobuf-java 3.0.2? If not, it is perhaps worth making a release just with updated dependencies. While we're there, I'd also recommend updating the cheshire dependency.

danielcompton commented 6 years ago

The version on master has a stable protobuf-java version, can you check if that fixes your problems?

jwr commented 6 years ago

I don't think there is any need to: I know that exclusion fixes the problems by using 3.0.2, and that the alpha version causes problems. Version 3.0.2 is used by ClojureScript 1.9.854, this is why I'm suggesting moving straight to 3.0.2 instead of 3.0.0 in the master, unless there are reasons not to (which I won't be able to judge quickly just by forcing the version down to 3.0.0).