apace100 / apoli

MIT License
40 stars 46 forks source link

Fix modifying damage power types not affecting certain projectiles #38

Closed eggohito closed 2 years ago

eggohito commented 2 years ago

There's an issue where power types such as modify_projectile_damage, modify_damage_taken, etc. does not work for projectiles like snowballs, ender pearls and llama spit. This PR fixes that issue by implementing how the damage value is modified from the LivingEntityMixin class to the PlayerEntityMixin class.

I had to do an exception for instances of PlayerEntity in the LivingEntityMixin class to avoid applying the modifier twice. This implementation should still work for arrows and tridents, which used to have their respective mixin classes before