search

apace100 / origins-classes

An add-on for the Origins mod which adds classes.
MIT License
15 stars 30 forks source link

Nerf merchant #47

Closed Pyxrs closed 3 years ago

Pyxrs commented 3 years ago

I'm currently running a modded SMP and I've noticed the merchant class is extremely overpowered. It could be used to obtain bedrock, dragon eggs, and more. This should fix that, as well slightly nerf the infinite trading thing (making it a less chance to use up a trade)

NOTE: Currently switching IDEs and my compiler is broken so I haven't checked if this will compile. Proceed with caution

apace100 commented 3 years ago

I'm sorry, but I won't merge this. The fun feature about playing merchant is that anything is possible with wandering traders, which - let's be honest here - are simply boring in the base game. Most items in Minecraft are not actually useful or valuable, so you won't get something valuable from them all the time when you're playing merchant, but there is the possibility that you'll get a jackpot and be able to buy for example a netherite chestplate for cheap! You basically just replaced the fun part with more useless trades which are about as exciting as the default trades the trader offers.

Also, in version 1.2.0, I changed the merchant class. Now, only obtainable items (they have to be in some loot table) can become available as offers. This means many of the items which were considered "broken" before (such as bedrock) are now unavailable. Additionally, there is now an item tag called origins-classes:merchant_blacklist, of which the items will be excluded from merchant trades.

If you still feel the merchant is unbalanced, you are welcome to add items to the merchant blacklist as you see fit, or of course change the merchant class altogether with a datapack for your server.

I'm sorry that I'm very persistent on this matter, but balancing is something everyone feels very differently (and somehow, very strongly) about. After I did the changes I described above, I immediately received a suggestion to add an option to bring the old ("broken") trades back. So there is just no pleasing everyone. But luckily, datapacks allow you to change (or disable) classes if you feel the need to. :)

Pyxrs commented 3 years ago

Oh, I didn't know about the patch. That fixes it! Thanks!