Open ghost opened 3 years ago
Can confirm it also conflicts with Gobber2: [✔️] Origins-Classes-1.16.3-1.1.0 [✔️] Gobber2-Fabric_1.16.4-2.3.38
java.lang.NullPointerException
at Not Enough Crashes deobfuscated stack trace.(1.16.4+build.7)
at net.minecraft.item.MiningToolItem.redirect$ecp000$applyMiningSpeedMultiplierMultiplier(MiningToolItem:1519)
at net.minecraft.item.MiningToolItem.getMiningSpeedMultiplier(MiningToolItem:38)
at net.minecraft.item.PickaxeItem.getMiningSpeedMultiplier(PickaxeItem:145)
at com.kwpugh.gobber2.items.tools.endtools.HammerEnd.isEffectiveOn(HammerEnd.java:55)
at net.minecraft.item.ItemStack.isEffectiveOn(ItemStack:359)
at com.kwpugh.gobber2.items.tools.endtools.HammerEnd.canMine(HammerEnd.java:39)
at net.minecraft.client.network.ClientPlayerInteractionManager.breakBlock(ClientPlayerInteractionManager:99)
at net.minecraft.client.network.ClientPlayerInteractionManager.updateBlockBreakingProgress(ClientPlayerInteractionManager:239)
at net.minecraft.client.MinecraftClient.handleBlockBreaking(MinecraftClient:1359)
at net.minecraft.client.MinecraftClient.handleInputEvents(MinecraftClient:1720)
Crash should be prevented in the newest version, however this was caused by the mods calling a method with a null item (potentially to calculate digging speed in some unspecified context). Therefore, while the game shouldn't crash anymore, you might see unexpected behaviour when using these tools.
Still not fixed: https://pastebin.com/tadAnFYm
Context is the following: I need to check if diamond tool digs block faster then 1.0f. Not a particular ItemStack but rather generic diamond tool.
return Items.DIAMOND_PICKAXE.getMiningSpeedMultiplier(null, blockIn) > 1.0f;
Fixed on TR side, but it's better to check if stack is null. https://github.com/TechReborn/TechReborn/commit/6877f6e3f2fba632200323028f8fb5e080f306bc
Can you provide full crash log, please?
Using a drill or saw from TechReborn results in this crash:
This happens with both Beta and Release versions of TechReborn.