search

apace100 / origins-fabric

MIT License
175 stars 170 forks source link

Humans Invincible #598

Open Sel1432 opened 2 years ago

Sel1432 commented 2 years ago

Hi, I recently set up an origins server with some friends, and one who picked the Human origin for a regular Minecraft experience is now immune to damage. Mobs still attack and move towards him but he won't take damage from anything, even after relogging. He also won't take drowning damage. We have yet to test of PvP damage affects him because he set up farther away from everyone and we're still early game Everyone who took an origin will take damage as normal for their origin (kinetic damage for elytrian, burning in sunlight for phantom) and from mobs. We're not sure what's causing it and I couldn't find a posted issue about it but I thought it was worth bringing to attention.

EDIT: NEVERMIND HE HADN'T PICKED THE HUMAN ORIGIN HE JUST HADN'T PICKED ANY ORIGIN AT ALL, THAT'S WHY. NOT SELECTING AN ORIGIN (if it's not an automatic pop up because of another mod perhaps?) MEANS YOU WON'T TAKE DAMAGE.

eggohito commented 2 years ago

This is an intentional side effect for having the 'Missing' origin (origins:empty). The 'Choose Origin' GUI being skipped might be caused by a datapack/mod modifying the origins:origin (data/origins/origin_layers/origin.json) origin layer

Ampflower commented 1 year ago

I was coming here to report similar; no origin should fall back to acting as human origin if the player moves a significant amount (sneaking speed with a >1 block difference since first login) not long after joining, either because they managed to close the UI, or a mod conflict.

Ampflower commented 1 year ago

This seems fixable by modifying https://github.com/apace100/origins-fabric/blob/1.19/src/main/java/io/github/apace100/origins/mixin/SelectionInvulnerabilityMixin.java to not cancel damage if there has been significant movement since join?