apace100 / origins-fabric

MIT License
175 stars 173 forks source link

Configurable Water Protection #711

Open sisby-folk opened 10 months ago

sisby-folk commented 10 months ago

Let's try this one more time!

This PR adds a new block to origins_server.json that allows individual toggling of water protection appearing in the enchanting table, on treasure books, and on treasure gear.

By default, water protection only appears on treasure books - this prevents origins from changing game balance even when human is selected (by reducing the odds to get useful enchantments at the table and on loot gear)

It also adds an option to disable the registration of the water protection enchantment entirely - this is a utility option for modpackers that don't use the water_vulnerability power at all, intended to allow them to ensure that water protection is completely unobtainable - and doesn't appear in recipe viewers or the creative screen. If toggled by an unaware user, this option will naturally prevent them from joining origins servers due to the registry mismatch, and could potentially cause a crash via an origins addon (though a nullable annotation was added to prevent this into the future) - however, I think the tradeoffs are worth it in this case.