Fix backspace crash, handle more chatbox use-cases

apace100 / show-me-what-you-got

Minecraft mod which allows displaying your items to other players in chat.

MIT License

6 stars 4 forks source link

Fix backspace crash, handle more chatbox use-cases #10

Closed hypevhs closed 1 year ago

hypevhs commented 1 year ago

Closes #6

This PR fixes the crash caused by off-by-one bug after deleting a tag and then sending the message. It also safeguards against any future similar bug, instead just logging it.

This PR is tested to handle more input use-cases like:

Delete key
Ctrl-Backspace
Ctrl-Delete
Ctrl-Left/Right (note: e.g. [Dirt] and [Dark Oak Log] are both considered one "word")
Cut, Paste
highlight backwards/forwards then backspace/delete/overwrite/cut/paste

However, tabbing through slash-command suggestions multiple times still puts you in an invalid state.

After this, I plan to port this to 1.19, where similar crashes occur.

hypevhs commented 1 year ago

Let me know if you want any logic changes, rebase, or squash/fixup

hypevhs commented 1 year ago

So, is there anything I can do to ease the merge process? Many players would enjoy being able to use this mod without fear of crashing.

apace100 commented 1 year ago

Thanks for the PR! The only adjustment I made afterwards was modifying the log output to use the mod-specific logger instead of the Fabric Loader log system, as you can see in this commit.

Regarding porting to 1.19, as far as I can tell the most recent version on 1.19.4 doesn't have these issues anymore.

hypevhs commented 1 year ago

@apace100 thank you! Regarding the 1.19 port, yes I believe 1.19.4 no longer has the crash issue. However the All of Fabric 6 modpack that I am ultimately trying to fix is on 1.19.2. This project was migrated off of 1.19.2 before the crash fixes were made.

Please create a "1.19.2" branch on the last commit to support that MC version: 18ebcf6.

When I have time, I will open a PR against that branch. The port implementation has already been completed and pushed on my fork, except I'd like to replicate the cleanups you made to this PR.

Thank you!