search

apache-spark-on-k8s / spark

Apache Spark enhanced with native Kubernetes scheduler back-end: NOTE this repository is being ARCHIVED as all new development for the kubernetes scheduler back-end is now on https://github.com/apache/spark/
https://spark.apache.org/
Apache License 2.0
612 stars 118 forks source link

Code enhancement: Replaced explicit synchronized access to a hashmap with a concurrent map. #392

Closed varunkatta closed 7 years ago

varunkatta commented 7 years ago

What changes were proposed in this pull request?

Refactored access to a HashMap through an explicit external lock with a implicit internal lock. Thread safe access to the map is maintained.

How was this patch tested?

Ran Unit-tests

liyinan926 commented 7 years ago

LGTM.

foxish commented 7 years ago

Thanks! This is not a bug-fix correct? If so, please hold off on merge till we cut the 0.3.0 for the 2.2 branch (just to keep 0.3.0 in sync with the 2.1 branch).

varunkatta commented 7 years ago

This is not a bug fix. Addressed a TODO for a general code enhancement. This code is not directly related to any specific feature work.

ash211 commented 7 years ago

It seems this PR has stalled a bit since the last activity a few weeks ago. @varunkatta what's next here?

varunkatta commented 7 years ago

Just back to this PR...I thought this PR was merged long back ; apparently not. I will address the last few comments today.

varunkatta commented 7 years ago

@satybald I addressed your comments. Do you want to take a quick look at the diff?

@ash211 Next steps, if there are no more changes requested by reviewers is to merge this PR.

ash211 commented 7 years ago

Going to bring in after https://github.com/apache-spark-on-k8s/spark/pull/459

ash211 commented 7 years ago

@varunkatta this is ready for rebase -- please fix merge conflicts