search

apache-spark-on-k8s / spark

Apache Spark enhanced with native Kubernetes scheduler back-end: NOTE this repository is being ARCHIVED as all new development for the kubernetes scheduler back-end is now on https://github.com/apache/spark/
https://spark.apache.org/
Apache License 2.0
612 stars 118 forks source link

Scala style guide tests fails #413

Closed satybald closed 7 years ago

satybald commented 7 years ago

During today SIG meetings, Spark Upstream Updates topic was discussed. One thing that community ask to fix code style issues. Currently, there are ~50 different issues in k8s module.

./dev/lint-scala
Scalastyle checks failed at following occurrences:
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/InitContainerResourceStagingServerSecretPlugin.scala:31:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/InitContainerResourceStagingServerSecretPlugin.scala:38:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/SubmittedDependencyUploaderImpl.scala:41:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/SubmittedDependencyUploaderImpl.scala:47:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/SubmittedDependencyUploaderImpl.scala:54:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/KubernetesFileUtils.scala:57:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/KubernetesFileUtils.scala:79:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/Client.scala:89:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/Client.scala:206:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/LoggingPodStatusWatcher.scala:40:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/DriverConfigurationStepsOrchestrator.scala:35:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/PropertiesConfigMapFromScalaMapBuilder.scala:25:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/KubernetesDriverSpec.scala:29:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/InitContainerBootstrapStep.scala:31:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/initcontainer/InitContainerConfigurationStep.scala:19:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/initcontainer/InitContainerConfigurationStepsOrchestrator.scala:34:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/initcontainer/InitContainerSpec.scala:21:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/BaseDriverConfigurationStep.scala:32:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/DriverConfigurationStep.scala:19:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/DriverConfigurationStep.scala:24:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/DependencyResolutionStep.scala:27:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/submitsteps/DriverKubernetesCredentialsStep.scala:36:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/config.scala:260: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/config.scala:324: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/config.scala:374: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/config.scala:424: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/KubernetesExternalShuffleService.scala:49:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/KubernetesExternalShuffleService.scala:142:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/SparkKubernetesClientFactory.scala:36:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/SparkPodInitContainerBootstrap.scala:29:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/SparkPodInitContainerBootstrap.scala:35:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/PemsToKeyStoreConverter.scala:37:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingServiceRetrofit.scala:25:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:38: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:84: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:36:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:55:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:83:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/ResourceStagingService.scala:95:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/StagedResourcesStore.scala:33:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/StagedResourcesStore.scala:39:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/KubernetesSparkDependencyDownloadInitContainer.scala:79:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/StagedResourcesOwner.scala:34: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesClusterSchedulerBackend.scala:448:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesClusterSchedulerBackend.scala:518:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesClusterSchedulerBackend.scala:929:0: Use Javadoc style indentation for multiline comments
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesTaskSetManager.scala:73: File line length exceeds 100 characters
[error] /home/ssatybaldiye/Documents/github/kube/spark-branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesTaskSetManager.scala:32:0: Use Javadoc style indentation for multiline comments
[error] (kubernetes/compile:scalastyle) errors exist
erikerlandson commented 7 years ago

@satybald thanks - the apache spark upstream CI fails anything that doesn't pass the style tests, so we will definitely have to address this as part of the eventual adoption workflow. cc @foxish @mccheah @kimoonkim @ifilonenko

satybald commented 7 years ago

I can take care of fixing style issues if no one mind. Though, why k8s-spark CI doesn't run style guide checks?

foxish commented 7 years ago

That is odd. Hmm, we used to run it under travis before.

satybald commented 7 years ago

I'm sorry, there are no issues with a style guide. The issue can be closed. I accidentally run scalafmt on the module, and completely forgot about it. Silly me.