search

apache-spark-on-k8s / spark

Apache Spark enhanced with native Kubernetes scheduler back-end: NOTE this repository is being ARCHIVED as all new development for the kubernetes scheduler back-end is now on https://github.com/apache/spark/
https://spark.apache.org/
Apache License 2.0
612 stars 118 forks source link

Rename package to k8s #497

Closed foxish closed 7 years ago

foxish commented 7 years ago

/xref https://github.com/apache-spark-on-k8s/spark/pull/492#discussion_r139560316

cc @apache-spark-on-k8s/contributors

foxish commented 7 years ago

Let's merge this after the new 2.2 release.

foxish commented 7 years ago

On second thought, maybe we should include this in the release. It will help folks migrate to the upstream one without jumping through hoops. WDYT @mccheah @liyinan926

liyinan926 commented 7 years ago

@foxish I think this should go into the new release. It's better doing it earlier than later. It makes the upcoming upstreaming PRs easier to go by.

foxish commented 7 years ago

Agreed. It's low-risk since the failures would have been fairly obvious.

ifilonenko commented 7 years ago

@varunkatta @ssuchter The Jenkins environment needs to be updated since the commands had a wildcard on deploy.kubernetes.* which has been changed to deploy.k8s.*

foxish commented 7 years ago

Good catch @ifilonenko! We should do this asap. Manually verifying that integration tests are okay.

ssuchter commented 7 years ago

I just saw this thread. I’m not sure what updates I’d need to make. Also, I’m mention - if anyone needs a jenkins UI login that doesn’t have it, just let me know.

Sean

On September 24, 2017 at 5:44:40 PM, Anirudh Ramanathan ( notifications@github.com) wrote:

Good catch @ifilonenko https://github.com/ifilonenko! We should do this asap. Manually verifying that integration tests are okay.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache-spark-on-k8s/spark/pull/497#issuecomment-331751697, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2E24EjAxqc7OviQ3wORISvDkn3wEhJks5slvd4gaJpZM4PdNLM .

foxish commented 7 years ago

The integration tests run:

./build/mvn -B -Dmaven.repo.local=/home/jenkins/.m2/pr_intg_test_repo clean integration-test -Pkubernetes -Pkubernetes-integration-tests -pl resource-managers/kubernetes/integration-tests -am -Dtest=none -DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite

We need to change the last argument to -DwildcardSuites=org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite. Can you create a login/pass for me and Ilan? Then we could probably do this directly.

ssuchter commented 7 years ago

I made the change already. I see that you both have usernames on the jenkins already - I’ll contact you on slack about that.

Sean

On September 25, 2017 at 8:48:49 AM, Anirudh Ramanathan ( notifications@github.com) wrote:

The integration tests run:

./build/mvn -B -Dmaven.repo.local=/home/jenkins/.m2/pr_intg_test_repo clean integration-test -Pkubernetes -Pkubernetes-integration-tests -pl resource-managers/kubernetes/integration-tests -am -Dtest=none -DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite

We need to change the last argument to -DwildcardSuites=org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite . Can you create a login/pass for me and Ilan? Then we could probably do this directly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache-spark-on-k8s/spark/pull/497#issuecomment-331924544, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2E23sw_6R_ka9-z_h4n4EZ-gFMEo-Fks5sl8tcgaJpZM4PdNLM .