search

apache-spark-on-k8s / spark

Apache Spark enhanced with native Kubernetes scheduler back-end: NOTE this repository is being ARCHIVED as all new development for the kubernetes scheduler back-end is now on https://github.com/apache/spark/
https://spark.apache.org/
Apache License 2.0
612 stars 118 forks source link

Use the new initContainers field instead of the deprecated annotation #528

Closed liyinan926 closed 6 years ago

liyinan926 commented 7 years ago

What changes were proposed in this pull request?

Fixes #524. Changes to use the new initContainers field instead of the deprecated annotation, support of which is dropped as of Kubernetes 1.8. This requires updating the version of the fabric8 kubernetes-client.

foxish commented 7 years ago

Any other interesting changes brought about by the fabric8 upgrade?

liyinan926 commented 7 years ago

@foxish will do some research on that.

liyinan926 commented 7 years ago

rerun integration tests please

liyinan926 commented 7 years ago

rerun integration tests please

liyinan926 commented 7 years ago

@felixcheung Yes, this change requires k8s 1.6 and up.

felixcheung commented 7 years ago

Hmm.. as a side note, I couldn't find description on k8s version requirements, could we add to README.md?

liyinan926 commented 7 years ago

@felixcheung good point. I will add to https://github.com/apache-spark-on-k8s/userdocs/blob/master/src/jekyll/running-on-kubernetes.md once this PR is merged.

liyinan926 commented 7 years ago

rerun integration tests please

liyinan926 commented 7 years ago

Doc updates for minimum k8s version requirement in https://github.com/apache-spark-on-k8s/userdocs/pull/18.

foxish commented 7 years ago

LGTM! Will merge EOD if no further comments.