mistercrunch commented 5 years ago

🏆 Enhancements

Upgrading to a recent deck.gl, this will enable creating the Kepler.gl plugin based on the latest Kepler. Deck.gl 6 and 7 break backward compatibility in intricate ways so the task wasn't easy.

This PR also reduce the chain of re-renders on viewState (viewport) changes. We used to carry the viewport up the React tree using onViewportChange methods and carrying the viewport back down. This would recompute layers when it wasn't in fact necessary and made things glitchy/laggy a bit. I now carry width/height down to the viewport, and only recompute layers when needed.

I tested manually a fair amount and even altered a core dataset using update long_lat set datetime = DATE_ADD(curdate(), INTERVAL FLOOR(RAND()*(20)) DAY); to create a test set for the animation. Also added a geohash5 column to the same dataset to test the categorical color component.

@betodealmeida

netlify[bot] commented 5 years ago

Deploy preview for superset-ui-plugins-deckgl ready!

Built with commit 2cdff916dbf67ce90a18729a798deb0c6b2db8f3

https://deploy-preview-1--superset-ui-plugins-deckgl.netlify.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is n/a.

@@         Coverage Diff          @@
##           master    #1   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files           1     1           
  Lines           4     4           
====================================
  Hits            3     3           
  Misses          1     1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7a029f...2cdff91. Read the comment docs.

betodealmeida commented 5 years ago

Awesome, I'll take a look today. We were just talking about getting rid of the private cherry for Kepler.

kristw commented 5 years ago

LGTM.

mistercrunch commented 5 years ago

@betodealmeida I want to get started on pluginifying Kepler, I'm merging this, happy to address any issues you find here in following PR.

apache-superset / superset-ui-plugins-deckgl

chore: upgrade to deck.gl 7.x #1

Codecov Report