search

apache / accumulo-access

Apache Accumulo Access Control Library
https://accumulo.apache.org
Apache License 2.0
4 stars 11 forks source link

rename contrib to examples #50

Closed keith-turner closed 9 months ago

DomGarguilo commented 9 months ago

I see two more mentions of the word "contrib" in the project: https://github.com/apache/accumulo-access/blob/caf21fa28ab3c4486d67d6719565f3466483b0bc/examples/antlr4/README.md?plain=1#L19

and "this contrib project" here: https://github.com/apache/accumulo-access/blob/caf21fa28ab3c4486d67d6719565f3466483b0bc/examples/antlr4/README.md?plain=1#L25

Do we want to change these or leave them?

keith-turner commented 9 months ago

Instead of merely changing the name of the directory, I'd like to try to merge the ANTLR stuff into the main project, either as src/main/resources, or as src/test/resources.

I think this is a nice improvement that could be merged for now. This changes makes the project a bit better than it was before, so not sure it makes sense to not make the change because of possible future improvements.

keith-turner commented 9 months ago

@DomGarguilo I updated the readme in f73e363

ctubbsii commented 9 months ago

Instead of merely changing the name of the directory, I'd like to try to merge the ANTLR stuff into the main project, either as src/main/resources, or as src/test/resources.

I think this is a nice improvement that could be merged for now. This changes makes the project a bit better than it was before, so not sure it makes sense to not make the change because of possible future improvements.

Except that renaming it conflicts with the work I'm currently in process of doing. See PR #51

ctubbsii commented 9 months ago

This is superseded by #51 (already merged) and #53