search

apache / accumulo-access

Apache Accumulo Access Control Library
https://accumulo.apache.org
Apache License 2.0
4 stars 11 forks source link

AccessExpression.abnf could be deleted #60

Closed dlmarion closed 9 months ago

dlmarion commented 9 months ago

src/main/resources/org/apache/accumulo/access/specification/AccessExpression.abnf exists for the sole purpose of validating that the ABNF in SPECIFICATION.md is valid ABNF. The contents of AccessExpression.abnf are a copy of the ABNF in SPECIFICATION.md. AccessExpressionTest.testSpecificationDocumentation and AccessExpression.abnf could be deleted and the method used in AccessExpressionTest.testSpecificationDocumentation to get the ABNF from SPECIFICATION.md could be used in SpecificationTest.

ctubbsii commented 9 months ago

I don't want to do that, because I think it's useful as a jar resource so it can be used as a dependency by other projects who might want to pull it in as the canonical definition.

dlmarion commented 9 months ago

ok, so that's why you added the test for equality between SPECIFICATION.md and AccessExpression.abnf. I'm fine with that, I just thought we wanted to remove the duplication.

ctubbsii commented 9 months ago

ok, so that's why you added the test for equality between SPECIFICATION.md and AccessExpression.abnf. I'm fine with that, I just thought we wanted to remove the duplication.

Yes, exactly. Deduplication was my preference, but I decided to punt on that for now. We could still deduplicate by removing it from SPECIFICATION.md... but I'm not sure how much affinity people had for having it there, rather than just having a link there to the abnf file.