apache / accumulo-proxy

Apache Accumulo Proxy
https://accumulo.apache.org
Apache License 2.0
9 stars 19 forks source link

Trivial: Use AccumuloITBase unique name method #46

Closed DomGarguilo closed 1 year ago

DomGarguilo commented 1 year ago

This PR replaces a stand-in method used to get unique names (created between upgrading JUnit versions) with AccumuloITBase.getUniqueNames()

DomGarguilo commented 1 year ago

If our goal is to no longer depend on Accumulo, except for public API, then we probably don't want to depend on things from Accumulo's test code either. If the tests are updated to use accumulo2-maven-plugin instead of extending our minicluster IT base classes, then they wouldn't have access to this convenience method, so we'd end up re-adding this method later anyway... so it's probably not worth doing this.

That makes sense, closing for now.