Update compaction techniques

apache / accumulo-proxy

Apache Accumulo Proxy

https://accumulo.apache.org

Apache License 2.0

9 stars 19 forks source link

Update compaction techniques #60

Closed DomGarguilo closed 1 year ago

DomGarguilo commented 1 year ago

This PR aims to replace the deprecated compaction methods with the new ones.

Fixes #47

a new thrift object was added for the PluginConfig
The compaction test was replaced with a test for supplying a custom CompactionSelector

I'm not sure that this is the best place to have the CompactionSelector as it is only used for testing so I will probably move it but just wanted to get something working together first.

I also plan on looking into adding a test for custom CompactionConfigurer too.

ctubbsii commented 1 year ago

I don't know enough about the new compaction configuration to review this. I requested a review from @keith-turner or @dlmarion , who I think could assess it better.

DomGarguilo commented 1 year ago

Everything looks good here to me and the tests pass when run with my IDE but when running in the terminal, there is an error Security sealing violation: package org.apache.accumulo.proxy is sealed that gets thrown when running the compaction IT that was modified in this PR. Not sure exactly whats going on here but I'm looking at moving the CompactionSelector that is currently in the test directory into its own Jar file.