In 65fd1bbf2494b4ae0071ca99ce8740943a6df479 I pushed some changes to wrap the Wait.waitFor() blocks in the tests in assertTrue(). The Wait.waitFor() method will not fail on its own and simply returns a boolean which was being ignored in all of the tests, and still is being ignored in testCompactionSelector.
checks to make sure that half of the files were compacted in accordance with the SelectHalfSelector being used in the test. After correctly checking the return value for this condition, it is evident that the selector is not working as intended and the number of files does not change after compaction.
In 65fd1bbf2494b4ae0071ca99ce8740943a6df479 I pushed some changes to wrap the
Wait.waitFor()blocks in the tests inassertTrue(). TheWait.waitFor()method will not fail on its own and simply returns a boolean which was being ignored in all of the tests, and still is being ignored in testCompactionSelector.The condition in the test,
checks to make sure that half of the files were compacted in accordance with the SelectHalfSelector being used in the test. After correctly checking the return value for this condition, it is evident that the selector is not working as intended and the number of files does not change after compaction.