search

apache / accumulo-testing

Apache Accumulo Testing
https://accumulo.apache.org
Apache License 2.0
15 stars 40 forks source link

Bump maven to 3.8.8 in terraform config #264

Closed DomGarguilo closed 1 year ago

DomGarguilo commented 1 year ago

Fixes #263

DomGarguilo commented 1 year ago

This is fine, but I wonder if it would be better to just have the instance do a yum install or apt-get install the version of Maven that ships with the OS of the base image, so we don't have to keep updating this. Maven is pretty stable from version to version, so it really doesn't matter which version we use, as long as it's relatively recent. We define the plugin versions we care about ourselves.

Seems like a good idea to me. I wonder if that would make it any harder to install a specific version of maven. I guess we might want to still have it as an option to pin a certain version for testing but again, not sure.

DomGarguilo commented 1 year ago

Going to merge this for now. Making the change mentioned above can be handled in a separate ticket.

dlmarion commented 1 year ago

This is fine, but I wonder if it would be better to just have the instance do a yum install or apt-get install the version of Maven that ships with the OS of the base image, so we don't have to keep updating this.

I think the only issue with this is that I think the Maven version for CentOS7 is really old, and CentOS7 is still widely used. I think it might be version 3.0.5.

ctubbsii commented 1 year ago

I don't think we need to still be supporting CentOS 7 for our testing repo's main branch (accumulo >= 3.0). The terraform scripts can be updated to use something newer, if they aren't already.