search

apache / accumulo-website

Apache Accumulo Website
https://accumulo.apache.org
14 stars 100 forks source link

Update webrick version #388

Closed ddanielr closed 1 year ago

ddanielr commented 1 year ago

Updating webrick version from 1.7.0 to latest version available.

DomGarguilo commented 1 year ago

The changes in Gemfile.lock were created automatically, right? Also were you able to verify that things still work with these changes?

ctubbsii commented 1 year ago

I'm not sure what webrick is even being used for. It was added in 4980f0d0519cdd02d17e5541f57590f093c8ee37 as part of an update by @jmark99 to use a JShell version of the tour, but I'm not sure what it's actually needed for.

I did a quick reset of my local ruby and gem installation and did a bundle install to ensure everything was updated, then I verified the generated differences were not significant. I did that commit in 17248a992b04e516d004e57ca16cbaad6ab5e628

ddanielr commented 1 year ago

The changes in Gemfile.lock were created automatically, right? Also were you able to verify that things still work with these changes?

yes they were created automatically once I updated the webrick version. I was able to successfully build the containerized dev environment with no issues. I was then able to render and host the website files.

@ctubbsii I think it might be a dependency for Jekyll? To test this, I removed webrick from the Gemfile, deleted my Gemfile.lock file and then did a bundle install. The contents of the new Gemfile.lock still list webrick 1.8.1.

ctubbsii commented 1 year ago

Resolved in 17248a992b04e516d004e57ca16cbaad6ab5e628