apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.06k stars 445 forks source link

Implement lifecycle logging #1316

Open keith-turner opened 5 years ago

keith-turner commented 5 years ago

Following the lifecycle of certain events in Accumulo via documented logical loggers would be really nice. For example it would be nice to be able to follow the lifecycle of a write ahead log across the master, tserver, and GC using a logger name like org.apache.accumulo.log.wal that does not correspond to any class. These logical loggers could be documented in the Accumulo user manual, like Fluo does.

Could have life cycle logging for the following events to start with

One way to implement this would be to create class with static methods for each life-cycle we want to log. For example all logging of tablet lifecycle events would be done in a single class via static methods. The advantage of this approach is that it brings all of the logging together in one place in the code which will lead to more consistent log messages.

Most existing log messages should not follow this approach.

keith-turner commented 5 years ago

Could use much shorter logger names like accumulo.tablet and accumulo.wal like Fluo does.

keith-turner commented 5 years ago

In addition to documenting the loggers in the user manual, it would be nice to create a schema for these log events that could be used by log stash apache/fluo-muchos#254

EdColeman commented 5 years ago

I'm interested in taking a run at this as well as #1249 - not assigning myself at this time in case other events delay me in starting to work the issue(s)