search

apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.07k stars 445 forks source link

OnDemand Follow-on: Create a public RowRange object with start/end rows and exclusivity booleans #3308

Open dlmarion opened 1 year ago

dlmarion commented 1 year ago

Reference comment at: https://github.com/apache/accumulo/pull/3294#discussion_r1167115920. There are a lot of places in the API where Text start and Text end can be set by the user to specify a Range. This task is about creating a common object that captures the start, end, and inclusivity of both, and then using that in all places in the API where a range is being passed.

DomGarguilo commented 1 year ago

@dlmarion do you think this change should be targeting the elasticity branch directly? Or should this new object be created and used in main and then merged into elasticity?

dlmarion commented 1 year ago

I think it depends on the implementation. I think you might be able to do the following and target main:

  1. Create new RowRange public API object
  2. Everywhere in the API where Text start/stop row values are being used, deprecate that method and create a new method that uses the new API object.

It's yet to be determined how/where the inclusivity arguments are used in the existing methods.