search

apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.06k stars 445 forks source link

Look into setting test server class before starting mini accumulo #4644

Open keith-turner opened 2 months ago

keith-turner commented 2 months ago 
          I'd bet that there are some other tests, related to Scan Servers and/or External Compactions, that could use this new method instead of stopping the "normal" implementation and starting a different one for the test. It's probably worth a new ticket for this.

_Originally posted by @dlmarion in https://github.com/apache/accumulo/pull/4643#discussion_r1630150595_

keith-turner commented 2 months ago

This issue is about determining if tests that call the following method

https://github.com/apache/accumulo/blob/f046289c1bf9d363ce51a8004510cd452e67167b/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java#L131

could use the following pattern instead.

https://github.com/apache/accumulo/blob/f046289c1bf9d363ce51a8004510cd452e67167b/test/src/main/java/org/apache/accumulo/test/functional/MergeFlakyFateIT.java#L33-L35

Probably depends on if the test uses the normal server class that was started before it starts a test one.

dlmarion commented 2 months ago

Probably depends on if the test uses the normal server class that was started before it starts a test one.

It probably only makes sense to use this new method when the test class only uses a single non-standard implementation. If the test class starts and stops different types of implementations, then this likely can't replace that functionality.