apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.07k stars 446 forks source link

scan servers use tserver prefix for cache manager property #4663

Open ddanielr opened 4 months ago

ddanielr commented 4 months ago

Describe the bug When trying to set the class to use for the cache manager, the scan servers do not use a sserver property prefix. Instead the scan servers only load in a different manager if tserver.cache.manager.class is set.

Versions (OS, Maven, Java, and others, as appropriate):

To Reproduce Steps to reproduce the behavior (or a link to an example repository that reproduces the problem):

  1. Setup an fluo-uno instance
  2. Modify the properties to set sserver.cache.manager.class=test.example in the property file.
  3. Try starting a scan server (This should succeed)
  4. Modify the properties file to set tserver.cache.manager.class=test.example
  5. Try starting a scan server (This will fail with a class not found error)

Expected behavior The scan server should use the sserver prefix when loading in instance properties.

Additional context There may be additional properties that are still only loaded in via the tserver prefix.

dlmarion commented 2 months ago

The 'tserver.cache.manager.class' property is also used by the RFileScanner in the client, so the property it not actually tserver specific. Do we need to support different block cache manager implementations between the client, tserver, and scan server? If not, then we should just make this a generic property.