search

apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.06k stars 445 forks source link

Look at collapsing MutableByteSequence into ArrayByteSequence #4738

Closed dlmarion closed 3 weeks ago

dlmarion commented 1 month ago

MutableByteSequence extends ArrayByteSequence with two method to modify the object, but ArrayByteSequence isn't immutable. MutableByteSequence is only used in 2 classes. Evaluate whether or not MutableByteSequence can be removed in favor of ArrayByteSequence with necessary modifications.

keith-turner commented 1 month ago

MutableByteSequence is not in a public API package so it would be easy to delete

meatballspaghetti commented 1 month ago

I can look into this.

dlmarion commented 1 month ago

@meatballspaghetti - Is there a pull request for your commit to merge it into the main repo?

meatballspaghetti commented 1 month ago

@meatballspaghetti - Is there a pull request for your commit to merge it into the main repo?

Yes, there is now #4745 .