search

apache / accumulo

Apache Accumulo
https://accumulo.apache.org
Apache License 2.0
1.07k stars 445 forks source link

Use Metric.getDescription() for all micrometer instruments #4925

Closed DomGarguilo closed 1 month ago

DomGarguilo commented 1 month ago

This serves to update all micrometer instruments to use the corresponding Metric.getDescription() for its description replacing hardcoded Strings.

We should also make an attempt to at least add a description for each metric in the Metric enum.

This work was already done for all existing instances in 3.1 so only new instances that only exist in 4.0 are being updated in this PR.

DomGarguilo commented 1 month ago

While working on this PR I noticed some improvements that could be made regarding FateMetrics so opened #4894 against the 3.1 branch. That PR touches some of the code that needs to be changed for the effort being made in this PR so I'll get that merged in here before we merge this one.

Edit: this has been taken care of in e583a59