apache / airavata-mft

Apache Airavata Managed File Transfer Services
https://airavata.apache.org
Apache License 2.0
32 stars 39 forks source link

single-service Implementation #67

Closed lahirujayathilake closed 1 year ago

lahirujayathilake commented 1 year ago

Wrapped api-service, resource-service, and secret-service into a single service.

DImuthuUpe commented 1 year ago

Looks great @lahirujayathilake. I have added a few comments, most to understand new annotations. I prefer to change the module name though. Can you check if you can integrate the controller and agent into this as well?

DImuthuUpe commented 1 year ago

Please add distribution building functionality into the pom. Here is an example https://github.com/apache/airavata-mft/blob/master/services/resource-service/server/pom.xml#L92

DImuthuUpe commented 1 year ago

Thanks @lahirujayathilake. Please address the review comments added above