search

apache / airflow-site

Apache Airflow Website
https://airflow.apache.org/
132 stars 279 forks source link

Add dark theme, by @prefers-color-theme #803

Closed vitaly-zdanevich closed 1 week ago

vitaly-zdanevich commented 1 year ago

What do you see as an issue?

For many users - difficult to read from the white background. Especially at low light conditions.

Solving the problem

By leveraging this CSS media query https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Anything else

No response

Are you willing to submit PR?

Code of Conduct

boring-cyborg[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

eladkal commented 1 year ago

Closing as duplicate of https://github.com/apache/airflow/issues/11334 This is indeed something we are looking into and it's planned as part of AIP-38

vitaly-zdanevich commented 1 year ago

But this is about documentation pages.

potiuk commented 1 year ago

But this is about documentation pages.

So it should be added to "airlfow-site" project - because this is where we keep our documentation website theme and everything. Please add it there.

eladkal commented 1 year ago

GitHub allows to transfer issues between repos.. let me try to transfer it to the airflow site repo

eladkal commented 1 year ago

@vitaly-zdanevich do you want to work on this issue and raise a PR?

vitaly-zdanevich commented 1 year ago

Maybe...

pierrejeambrun commented 1 year ago

@vitaly-zdanevich just assigned you :)

porwalshreyaa commented 1 month ago

Hey @vitaly-zdanevich, are you still working on it? Or else I am willing to take this issue as no dark mode is too much trouble for me 😢😭

eladkal commented 4 weeks ago

@porwalshreyaa assigned to you

vitaly-zdanevich commented 4 weeks ago

Hi, I am not using Airflow now, feel free to do it as you want...

mayo7e commented 3 weeks ago

@eladkal @porwalshreyaa i'll like to join in on this , see if we can get this done in a short time., this is a real blocker for me too.

potiuk commented 3 weeks ago

Feel free @mayo7e -> dark mode is added already in upcoming Airflow 2.10 -> https://github.com/apache/airflow/pull/39355, already works in main, probably what is needed is to enable it automatically by @prefers-color-theme -> if it does not work like that already.

potiuk commented 3 weeks ago

BTW. The PR for dark mode got the title of "PR of the month" in June unanimously, so you are not the only want that considered that as a blocker - see https://lists.apache.org/thread/fnlswr7w69oofxp6g8rkc5052yxc7rs2

porwalshreyaa commented 3 weeks ago

@potiuk why did you unassign me? I am still working on it and he asked to join me, maybe you could just assign us both?

potiuk commented 3 weeks ago

Ups. FAT FINGERS

mayo7e commented 3 weeks ago

@potiuk great , on it!

porwalshreyaa commented 3 weeks ago

@potiuk Thanks! I've told my friends that I am working on this, if I don't get to merge, I'll be in trouble 😂

mayo7e commented 3 weeks ago

@porwalshreyaa happy to work with you on this! Is there a feature branch you already created that I can clone? If you have the tasks defined, I can get started with a task right away. If not, perhaps we can start by defining the tasks together.

porwalshreyaa commented 3 weeks ago

@mayo7e I haven't created a branch yet, I just read the mdn doc. Maybe we can do divide pages you can do one page completely by yourself and I'll do another, or you have something else in mind? I am yet to define tasks

mayo7e commented 3 weeks ago

@porwalshreyaa Perhaps you can point me to the MDN documentation in question so I can get up to speed. I'm not sure what you mean by "divide pages." According to @potiuk , all that remains is adding the functionality for OS theme preference to be reflected in the Airflow UI while still keeping the toggle button option available.

porwalshreyaa commented 3 weeks ago

@mayo7e mdn css preference

porwalshreyaa commented 3 weeks ago

@mayo7e by divide I meant to distribute tasks among us

mayo7e commented 3 weeks ago

@porwalshreyaa Alright, I'll take some time to go over the documentation and share my thoughts on how we can divide the tasks or perhaps you have thoughts on this already?.

mayo7e commented 3 weeks ago

@mayo7e mdn css preference

thanks

porwalshreyaa commented 3 weeks ago

@mayo7e I am reading the code rn. Let's discuss it after we are both done. Btw, right now it's 5.30 pm in India. Are you available 4-5 hours later or it'll be too late for you to discuss?

mayo7e commented 3 weeks ago

@porwalshreyaa 4/5 hrs sounds fine. i will be doing same with the code...

potiuk commented 3 weeks ago

@potiuk I am reading the code rn. Let's discuss it after we are both done. Btw, right now it's 5.30 pm in India. Are you available 4-5 hours later or it'll be too late for you to discuss?

I have almost no knowledge there to discuss and we usually discuss things offline in PRs, I doubt there is a need for synchronous call and spending time of few people trying to set-it-up on call while it can be discussed offline

porwalshreyaa commented 3 weeks ago

@potiuk sorry I mentioned you instead of @mayo7e

potiuk commented 3 weeks ago

:D

mayo7e commented 1 week ago

@potiuk I think this has been implemented already, having to upgrade my RAM so i can run locally via docker for test. Also watched your demo on this at the meetup

potiuk commented 1 week ago

Yes. I think having it persistent (rather than use media query) is good enough.,