Open FHoffmannCode opened 3 years ago
Thanks for opening your first issue here! Be sure to follow the issue template!
This issue spawn from https://github.com/apache/airflow/pull/10991#discussion_r500837769 It probably can be useful but it's also a breaking change and so far I didn't see users complaining about it. Could you please clarify the TODO part on this issue? What operators need adjustments? Is it localized to GCP or also other providers?
Yeah I don’t see how this could break user code in practice. Should be doable.
Yeah. Nice feature to add. Would you like to implement it @FHoffmannCode ? Should I assign it to you ?
Yeah I don’t see how this could break user code in practice.
The suggestion was to change the returned value to make operators consistent. If changed then the value pushed to xcom is not as users are expecting.
It depends on what are correctly being returned; I’m assuming most (if not all) are currently returning None, which won’t have backward compatibility issues (except if someone is depending on an XCom is not pushed, but why would anyone do that). Are there instances of an operator currently pushing something else?
Yeah. Same here. I think it's no harm to return "more".
This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.
@eladkal Please assign me
assigned
Description
Currently some storage operators return files destination uris list for example
GoogleSheetsToGCSOperator
. It would be a good idea to make all of such operators to return this list.Use case / motivation