Grid view - Show vertical lines at rounded date intervals

hterik commented 2 years ago

Description

When looking at the DAG grid view, i want a quick overview of how many dags were run today. In grid view now (Airflow 2.3.2), there are some vertical lines inserted on the grid view that at first glance appear to be one per day, but looking closer actually have some other unpredictable interval.

See following example If you don't look at the popup and only consider the vertical lines in the background, it appears like the last 2 runs were on June 28, when they were actually both run on June 29. The time intervals in same picture are also very unintuitive, (13:02 to 14:27 = 1h25min and then 14:27 to 16:35 = 2h8min )

I understand this could be difficult since the number of runs in each interval can differ and each box in the grid has a fixed width. Some improvements should still be possible

Align the first line to closest minute/hour/day. From there, only increase the time in rounded intervals
Always add a new line for the latest day/hour/minute, depending on the total timespan displayed.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

NaveenGokavarapu19 commented 2 years ago

hii hterik. Can beginner handle this issue. Please let me know the difficulity of the issue.

bbovenzi commented 1 year ago

It's not a time-based, but display-based (every 10 dag runs). This was the simplest solution at the time. DAGs can have all sorts of different schedules (especially with manually triggered runs) which makes it harder to find a solution that works everywhere.

@NaveenGokavarapu19 I'd be happy to help you get a solution working. We'd have to check the whole range of the first to last dag runs displayed and from that overall timeline, select relevant dates to render (change in every hour, 6 hours, day, week, etc).

apache / airflow