apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
36.56k stars 14.16k forks source link

Metrics - airflow_local_task #32161

Open ferruzzi opened 1 year ago

ferruzzi commented 1 year ago

Apache Airflow version

2.6.2

What happened

It is my understanding that the airflow_local_task_* metric is only called when the task is explicitly called using airflow cli command, locally. It is getting triggered and reported by StatsD for DAGs run in the UI, but not getting reported by OTel.

I'm not sure if the bugfix here is that this should not be getting emitted in either one when triggered via GUI, or if we need to figure out why OTel is not getting it.

I am submitting this as an Issue since I will be a little distracted for the next bit and figured someone may be able to have a look in the meantime. Please do not assign it to me, I'll get it when I can is nobody else does.

What you think should happen instead

Behavior should be consistent.

How to reproduce

To reproduce, you can run Breeze with the statsd or the otel integration (for example breeze start-airflow --integration otel) and run the following DAG, then open the OTel or StatsD raw data view to verify.

from airflow import DAG
from airflow.decorators import task
from airflow.utils.timezone import datetime

@task
def task1():
    return 'Hello'

@task
def task2():
    return 'World!'

@task
def task3(in1, in2):
    print(f'{in1} {in2}')

with DAG(
    dag_id='taskflow_demo',
    start_date=datetime(2021, 1, 1),
    schedule=None,
    catchup=False
) as dag:

    task3(task1(), task2())

You will find the following output in the StatsD logs, but no matching values in the OTel logs

# HELP airflow_local_task_job_task_exit Metric autogenerated by statsd_exporter.
# TYPE airflow_local_task_job_task_exit counter
airflow_local_task_job_task_exit 3
# HELP airflow_local_task_job_task_exit_3_taskflow_demo_task2_0 Metric autogenerated by statsd_exporter.
# TYPE airflow_local_task_job_task_exit_3_taskflow_demo_task2_0 counter
airflow_local_task_job_task_exit_3_taskflow_demo_task2_0 1
# HELP airflow_local_task_job_task_exit_4_taskflow_demo_task1_0 Metric autogenerated by statsd_exporter.
# TYPE airflow_local_task_job_task_exit_4_taskflow_demo_task1_0 counter
airflow_local_task_job_task_exit_4_taskflow_demo_task1_0 1
# HELP airflow_local_task_job_task_exit_5_taskflow_demo_task3_0 Metric autogenerated by statsd_exporter.
# TYPE airflow_local_task_job_task_exit_5_taskflow_demo_task3_0 counter
airflow_local_task_job_task_exit_5_taskflow_demo_task3_0 1

Operating System

ubuntu

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

Code of Conduct

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.

potiuk commented 3 months ago

not stale