apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
36.86k stars 14.25k forks source link

Status of testing Providers that were prepared on July 06, 2023 #32389

Closed eladkal closed 1 year ago

eladkal commented 1 year ago

Body

Issue title: Status of testing Providers that were prepared on July 06, 2023

I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider alibaba: 2.5.0rc2

The guidelines on how to test providers can be found in

Verify providers by contributors

All users involved in the PRs: @darkag @raphaelauv @blcksrx @vandonr-amz @jhbigler @potiuk @Lee-W @bkossakowska @nathadfield @dcoliversun @phanikumv @pankajastro @aagateuip @joaopamaral @Adaverse @JDarDagran @moiseenkov @Joffreybvn @eladi99 @hussein-awala @notatallshaw-gts @Owen-CH-Leung @shahar1 @eladkal @utkarsharma2 @sunank200 @syedahsn @kristopherkane @cjames23 @ahidalgob @HaeSe0ng

Committer

Joffreybvn commented 1 year ago

32304 Works fine. Kerberos is installed when doing pip install apache-airflow-providers-apache-impala[kerberos]

JDarDagran commented 1 year ago

32345 works fine - tested both with hook_params and deprecated runtime_parameters.

31398 , #32371 are added too. There's however a bug fixed in #32400 which is not exposed though as there's no release of OpenLineage provider yet (method with a bug is never called without the OL provider). Would be nice to include this in this release cycle, I guess?

eladkal commented 1 year ago

There's however a bug fixed in https://github.com/apache/airflow/pull/32400 which is not exposed though as there's no release of OpenLineage provider yet (method with a bug is never called without the OL provider). Would be nice to include this in this release cycle, I guess?

Thanks for verifying This is not a blocker for this release since the OL integration doesn't work anyway (as OL provider is not yet available) the bug is locallized to OL part. For the moment I see no reason to have RC3, The fix will be included in future release of the provider.

Lee-W commented 1 year ago

We tested our example, DAGs with the following rc without encountering any error

pankajkoti commented 1 year ago

For #31920 I have a question which I have asked here https://github.com/apache/airflow/pull/31920#issuecomment-1623629476

darkag commented 1 year ago

tested #32089, works as expected

vandonr-amz commented 1 year ago

good for me, even if I'd prefer an RC3 to sneak some not-yet-breaking changes in there.

Adaverse commented 1 year ago

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

potiuk commented 1 year ago

Checked #32334 :+1:

image

vs (6.2.1)

image

dcoliversun commented 1 year ago

Checked #31787, thanks for your work @eladkal

eladkal commented 1 year ago

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

Can you also check 32270 ?

phanikumv commented 1 year ago

32034 and #31872 are working fine

jhbigler commented 1 year ago

31950 is working, I used apache-airflow-providers-trino==5.2.0rc2 and tested it against our development trino instance, I can verify the Trino hook reads the jwt file from disk and successfully authenticates with trino.

Adaverse commented 1 year ago

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

Can you also check 32270 ?

Tested with the above versions of providers of Amazon and Microsoft #32270 works as expected. Thanks, @eladkal

kristopherkane commented 1 year ago

Tested #32216 in local Airflow against real GCP Dataproc jobs.

eladkal commented 1 year ago

Amazon and Elasticsearch are excluded from RC2 (RC3 will be cut seperatly) The rest of providers are not affected

utkarsharma2 commented 1 year ago

Tested #31596 https://github.com/apache/airflow/pull/31596, working as expected.

On Sat, Jul 8, 2023 at 12:21 AM eladkal @.***> wrote:

Amazon and Elasticsearch are excluded from RC2 (RC3 will be cut seperatly) The rest of providers are not affected

— Reply to this email directly, view it on GitHub https://github.com/apache/airflow/issues/32389#issuecomment-1625886602, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLAHKTQ3NR6BIU7ECEWUDXPBLCXANCNFSM6AAAAAAZ74VIAU . You are receiving this because you were mentioned.Message ID: @.***>

hussein-awala commented 1 year ago

I have tested my changes and all of them work as expected. For #31803, it addresses a part of the problem, but there are still remaining issues in some use cases that need to be resolved, however no need for a new RC, we can release them in next releases, and the merged PR is necessary.

eladkal commented 1 year ago

Thank you everyone. Providers are released except Amazon and Elasticsearch which we will have RC3.

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

raphaelauv commented 1 year ago

Hey , I did not test on time the K8S providers -> there is a bug on the release

https://github.com/apache/airflow/issues/32458

eladkal commented 1 year ago

Hey , I did not test on time the K8S providers -> there is a bug on the release

32458

Provider already released. When fix is merged it will be released in the next provider wave

potiuk commented 1 year ago

Provider already released. When fix is merged it will be released in the next provider wave

We could consider yanking it.

eladkal commented 1 year ago

We could consider yanking it.

We shouldn't I don't think its a major bug and if we yank kubernetes we must also yank google and cancel amazon rc4 (currently in vote) as they use new feature released in kubernetes provider.

I will cut new release for kubernetes as soon as possible (can't right now because we have another provider vote in progress)

potiuk commented 1 year ago

Sure. No problem with that :)