Closed eladkal closed 7 months ago
@potiuk , @eladkal , hi, Could we please include #37282 into the release?
@potiuk , @eladkal , hi, Could we please include #37282 into the release?
If PR missed cut off time there is no option to add it. It will have to wait for next release / RC2 if we will have one.
Observing an issue with common.sql: 1.11.0rc2
Posted a question on the PR
Observing an issue with common.sql: 1.11.0rc2
Posted a question on the PR
Nice catch @pankajkoti
Nice catch @pankajkoti
Actually, it was the (Astronomer) Providers RC automation test suite that reported this failure :) Thank you @potiuk for providing the fix PR https://github.com/apache/airflow/pull/37359 so quick. Appreciate it 🙏🏽
https://github.com/apache/airflow/pull/37300 looks good. Also, @Lee-W , thank you for that fix to GKE providers.
However, I have deferrable tasks that should be completing that are not completing due to https://github.com/apache/airflow/pull/37279. Will comment on the PR there. cc @pankajastro @pankajkoti
Link to comment: https://github.com/apache/airflow/pull/37279#issuecomment-1938757838
However, I have deferrable tasks that should be completing that are not completing due to https://github.com/apache/airflow/pull/37279. Will comment on the PR there. cc @pankajastro @pankajkoti
Thanks for testing it. please share the DAG and other details if possible.
Hmm... I am struggeling to build a recent version of Airflow with celery 3.6.0rc1
. The issue seems unrelated to the changes in the provider. I tried to build a container with 2.9.0 but there FAB provider seems to be missing / not installable...
Hmm... I am struggeling to build a recent version of Airflow with
celery 3.6.0rc1
. The issue seems unrelated to the changes in the provider. I tried to build a container with 2.9.0 but there FAB provider seems to be missing / not installable...
Yes. FAB provider and Airflow 2.9.0 are not yet usable to install. We might want to change that and release FAB provider in the next wave
Added https://github.com/apache/airflow/pull/37362 to make the provider "ready" (we will need to do it when we come closer to 2.9.0 release.
https://github.com/apache/airflow/pull/36996 and https://github.com/apache/airflow/pull/37192 works as expected
I tested a random sample of changes from #36876 and it works OK. The PR simply changed the warnings.warn to decorator.
Tried out https://github.com/apache/airflow/pull/37214 using some sample DAGs in breeze environment. Looks good 👍🏽
Tried out #37211
amazon provider - 8.17.0:
amazon provider - 8.18.0rc1:
Info Log is no longer printed. hence, working as expected.
Tried out #37337 https://github.com/apache/airflow/pull/37337, works like a charm.
Provider apache-airflow-providers-hashicorp==3.6.3rc1
Le lun. 12 févr. 2024 à 17:37, Kalyan @.***> a écrit :
Tried out #37211 https://github.com/apache/airflow/pull/37211
amazon provider - 8.17.0: image.png (view on web) https://github.com/apache/airflow/assets/20266953/f96c054b-a6fe-4021-a0e5-ecfa5a76c23b
amazon provider - 8.18.0rc1: image.png (view on web) https://github.com/apache/airflow/assets/20266953/f727596c-51d6-4c88-a06f-9a74e408a2a9
Log is no longer printed. hence, working as expected.
— Reply to this email directly, view it on GitHub https://github.com/apache/airflow/issues/37358#issuecomment-1939109668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7LNNVW4RMJ3ZBCIZAWTGDYTJANRAVCNFSM6AAAAABDERZ2CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGEYDSNRWHA . You are receiving this because you were mentioned.Message ID: @.***>
Tested #37110 and #37323 and they both work as expected.
While testing #37137 I encountered an unexpected behaviour with the ECS executor not retrying on failures. I don't think it was caused by this change, it's a separate regression I believe. However, this executor is still experimental so I'm not sure it should block this release. CC @ferruzzi @syedahsn @shubham22
Checked all my changes. LGTM.
https://github.com/apache/airflow/pull/36685 doesn't work as expected. It stucks somehow. Will take a deeper look these days.
https://github.com/apache/airflow/pull/37306 and https://github.com/apache/airflow/pull/37081 works fine without cncf.kubernetes: 8.0.0rc1 Looks like https://github.com/apache/airflow/pull/37279#issuecomment-1938782796 is the root cause
Provider qdrant: 1.0.0rc1 https://github.com/apache/airflow/pull/36805
Tested DAGs. Works.
Providers amazon
, cncf.kubernetes
and common.sql
will be excluded from RC1.
Databricks providers, confirm #37025 works when xcom is disabled. However it raises error with xcom enabled when serializing named tuple to json.
However it raises error with xcom enabled when serializing named tuple to json.
Serializing named tuple should be add into the core first, e.g. it might be added by https://github.com/apache/airflow/pull/37168
Checked all my changes, looking good
Tested Add deferrable param in SFTPSensor (#37117) https://github.com/apache/airflow/pull/37117 and Fix metadata override for ComputeEngineSSHHook (#37192) https://github.com/apache/airflow/pull/37192: @molcay https://github.com/molcay works as expected.
Thanks, Utkarsh Sharma
On Wed, Feb 14, 2024 at 2:41 PM Pankaj Koti @.***> wrote:
37117 https://github.com/apache/airflow/pull/37117 works as expected
— Reply to this email directly, view it on GitHub https://github.com/apache/airflow/issues/37358#issuecomment-1943347598, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLAHM3XVNAOIW7XIDQ5GTYTR5SJAVCNFSM6AAAAABDERZ2CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGM2DONJZHA . You are receiving this because you were mentioned.Message ID: @.***>
Fix hanging KPO on deferrable task with do_xcom_push (#37300): @vchiapaikeo
work :+1:
However, I have deferrable tasks that should be completing that are not completing due to #37279. Will comment on the PR there. cc @pankajastro @pankajkoti
Link to comment: #37279 (comment)
Hey @vchiapaikeo would it be possible for you to test https://github.com/apache/airflow/pull/37363 with your use case?
However, this executor is still experimental so I'm not sure it should block this release.
Since we are having RC2 for amazon provider there is time to fix it if you can raise a PR? @o-nikolas
36685 doesn't work as expected. It stucks somehow. Will take a deeper look these days.
37306 and #37081 works fine without cncf.kubernetes: 8.0.0rc1 Looks like #37279 (comment) is the root cause
I tested #36685 a few more times today. The issue can no longer be reproduced.
Body
I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers?
The guidelines on how to test providers can be found in
Verify providers by contributors
Let us know in the comment, whether the issue is addressed.
Those are providers that require testing as there were some substantial changes introduced:
Provider amazon: 8.18.0rc1
log_query
to format SQL statement correctly inAthenaOperator
(#36962): @ferruzziBatchSensor
(#37234): @vincbeckProvider apache.beam: 5.6.1rc1
Provider apache.drill: 2.6.1rc1
Provider apache.druid: 3.8.1rc1
Provider apache.hive: 7.0.0rc1
Provider apache.livy: 3.7.2rc1
Provider apprise: 1.2.2rc1
Provider celery: 3.6.0rc1
task_acks_late
configuration to Celery Executor (#37066): @ninsblProvider cncf.kubernetes: 8.0.0rc1
SparkKubernetesOperator.template_body
(#37271): @Taragolis__init__
inKubernetesPodOperator
(#37010): @romsharon98Provider common.io: 1.3.0rc1
Provider common.sql: 1.11.0rc2
Provider databricks: 6.2.0rc1
Provider dbt.cloud: 3.6.1rc1
Provider elasticsearch: 5.3.3rc1
pendulum.from_timestamp
usage (#37160): @TaragolisProvider google: 10.15.0rc1
__init__
incustom_job
(#36789): @romsharon98__init__
inCloudDataTransferServiceCreateJobOperator
(#36909): @romsharon98Provider hashicorp: 3.6.3rc1
VAULT_TOKEN
support (#37337): @V0lantisProvider http: 4.9.1rc1
Provider influxdb: 2.4.1rc1
Provider jdbc: 4.2.2rc1
Provider microsoft.mssql: 3.6.1rc1
Provider mongo: 4.0.0rc1
MongoHook.conn_name_attr
tomongo_conn_id
(#37104): @TaragolisProvider mysql: 5.5.3rc1
Provider oracle: 3.9.2rc1
Provider pagerduty: 3.6.2rc1
Provider postgres: 5.10.1rc1
Provider qdrant: 1.0.0rc1
Provider sftp: 4.9.0rc1
Provider slack: 8.6.1rc1
Provider snowflake: 5.3.1rc1
Provider sqlite: 3.7.1rc1
Provider ssh: 3.10.1rc1
Provider tableau: 4.4.2rc1
Provider trino: 5.6.2rc1
Provider vertica: 3.7.1rc1
Provider weaviate: 1.3.2rc1
Provider yandex: 3.9.0rc1
All users involved in the PRs: @ellisms @moiseenkov @synsh @Anush008 @infohash @shardbread @raphaelauv @hussein-awala @molcay @pankajastro @selimchergui @dabla @rawwar @SuperBo @ninsbl @V0lantis @kacpermuda @ahzaz @dirrao
Committer