apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
37.12k stars 14.31k forks source link

Neo4j SQL Misnomer #39860

Open ThomasThelen opened 5 months ago

ThomasThelen commented 5 months ago

Apache Airflow Provider(s)

neo4j

Versions of Apache Airflow Providers

No response

Apache Airflow version

2.9.0

Operating System

macOS

Deployment

Docker-Compose

Deployment details

No response

What happened

The Neo4jOperator makes reference to executing sql, when the actual query language is cypher. SQL is not used to query graph databases, and Neo4j doesn't support SQL.

This was confusing to me because I had to make sure that the operator in fact, was using CYPHER instead of sql.

The example here uses CYPHER, but passes it into the sql kwarg which is confusing/misleading/incorrect.

What you think should happen instead

Instead of the operator taking a sql kwarg it should be renamed to cypher to match the actual query language being used.

How to reproduce

Reproduce by looking at the source https://github.com/apache/airflow/blob/main/airflow/providers/neo4j/operators/neo4j.py#L31

Anything else

No response

Are you willing to submit PR?

Code of Conduct

boring-cyborg[bot] commented 5 months ago

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.