Connection edit page says "Changed Row" even if field changes were not saved

techgnosis commented 3 months ago

Apache Airflow version

2.9.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

If you enter information into a field in a google_cloud_platform connection that is backed by a BS3TextFieldWidget, then you can never delete the information from that field. That behavior is not the bug, however. The bug is that if you delete the info from the field and click Save, the green "Changed Row" banner comes up, which is misleading. There is in fact no way to change that data once those fields have been saved with data in the connection. You must delete the connection if you want those fields to be empty.

What you think should happen instead?

Let the user know that Airflow is aware that those fields cannot be deleted. Right now it feels like its broken when really its a provider limitation.

How to reproduce

Watch the example video https://github.com/apache/airflow/assets/9045962/b9681ee0-2d8c-4463-b284-9913f8033ae5

Quick summary - Create a GCP connection Put a value in Credential Configuration file Put a value in Keyfile secret name Save Edit Delete those values Save See the "Changed Row" banner Edit See the values still there

Operating System

Airflow is running in AR 11.4.0

Versions of Apache Airflow Providers

apache-airflow-providers-google==10.18.0

Deployment

Astronomer

Deployment details

Browser is Safari

Anything else?

No response

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

boring-cyborg[bot] commented 3 months ago

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

lh5844 commented 2 months ago

Hello! I'm interested in this issue, may I be assigned to this?

apache / airflow