search

apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
35.21k stars 13.76k forks source link

extra being passed to SQLalchemy #40391

Closed aritra24 closed 2 days ago

aritra24 commented 5 days ago

The edit prefills an empty extra field (None) with a empty dictionary, which is decoded to an extra field being passed in the con url.

Fixes: #40056

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

aritra24 commented 5 days ago

Not entirely sure if this is the place to do the fix, or perhaps while creating the url we check for empty extra here? I guess it would be better to not prefill an empty dict?

aritra24 commented 2 days ago

@uranusjr could you please merge this. I don't have merge rights :p