search

apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
35.21k stars 13.76k forks source link

add timeout to influx db #40439

Closed romsharon98 closed 1 day ago

romsharon98 commented 2 days ago

passing extra to influxDB. close this thread in slack:

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

potiuk commented 2 days ago

Hmm. I guess we should add (or modify) existing test to test for it. I find it highly suspicious when such changes pass without any test modifications - it makes me think some tests are missing.

romsharon98 commented 2 days ago

Hmm. I guess we should add (or modify) existing test to test for it. I find it highly suspicious when such changes pass without any test modifications - it makes me think some tests are missing.

Yes, you were right. The tests didn't check much (or at all). I've updated them.

potiuk commented 1 day ago

Cool. Thanks!