utkarsharma2 commented 2 weeks ago

Body

We are kindly requesting that contributors to Apache Airflow RC 2.10.1rc1 help test the RC.

Please let us know by commenting if the issue is addressed in the latest RC.

[ ] Fix try selector refresh (#41483) (#41503): @bbovenzi Linked issues:
- Fix try selector refresh (#41483)
[ ] Field Deletion Warning when editing Connections (#41144) (#41504): @bbovenzi @lh5844 Linked issues:
- Field Deletion Warning when editing Connections (#41144)
[x] Fix UI rendering when XCom is INT, FLOAT, BOOL or NULL (#41516) (#41605): @jscheffl
[ ] [Backport] Fix InletEventsAccessors type stub (#41572) (#41607): @uranusjr
[x] Apply GitHub workflow changes to stable branch (#41623): @potiuk
[x] Adding url sanitisation for extra links (#41665) (#41680): @amoghrajesh
[x] [Backport] Splitting syspath preparation into stages (#41694): @amoghrajesh @uranusjr Linked issues:
- Splitting syspath preparation into stages (#41672)
[x] fix log for notifier(instance) without name (#41591) (#41699): @obarisk
[x] Adding rel property to hyperlinks in logs (#41696) (#41783): @amoghrajesh
[x] Remove deprecation warning for cgitb in Plugins Manager (#41732) (#41793): @potiuk
[x] Keep FAB compatibility for versions before 1.3.0 in 2.10 (#41549) (#41809): @joaopamaral
[ ] Don't Fail LocalTaskJob on heartbeat (#41704) (#41810): @collinmcnulty @jedcunningham Linked issues:
- Don't Fail LocalTaskJob on heartbeat (#41704)
[ ] Fix: DAGs are not marked as stale if the dags folder change (#41433) (#41829): @utkarsharma2
[x] Set end_date and duration for triggers completed with end_from_trigger as True (#41834): @Lee-W
[x] [Backport] logout link in no roles error page fix (#41813) (#41845): @gagan-bhullar-tech @shahar1 Linked issues:
- logout link in no roles error page fix (#41813)
[ ] Handle Example dags case when checking for missing files (#41856) (#41874): @utkarsharma2 Linked issues:
- DAGs are not marked as stale if the AIRFLOWCOREDAGS_FOLDER changes (#41432)
[x] Bump webpack from 5.76.0 to 5.94.0 in /airflow/www (#41864) (#41879): @potiuk
[x] Adding tojson filter to example_inlet_event_extra example dag (#41873) (#41890): @potiuk
[x] Make Scarf usage reporting in major+minor versions and counters in buckets (#41898) (#41900): @jscheffl
[x] Add backcompat check for executors that don't inherit BaseExecutor (#… (#41927): @potiuk
[x] Protect against None components of universal pathlib xcom backend (#4… (#41938): @potiuk Linked issues:
- Universal-pathlib 0.2.3 seems to break compatibility with 0.2.2 (at least breaks mypy checks). (#41723)
[x] Lower down universal-pathlib minimum to 0.2.2 (#41939) (#41943): @potiuk

Thanks to all who contributed to the release (probably not a complete list!): @gagan-bhullar-tech @obarisk @uranusjr @utkarsharma2 @bbovenzi @lh5844 @jedcunningham @amoghrajesh @jscheffl @shahar1 @potiuk @joaopamaral @collinmcnulty @Lee-W

Committer

[X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.

obarisk commented 2 weeks ago

41591 works as expected

tested with airflow.providers.slack.notifications.slack_webhook.send_slack_webhook_notification and airflow.providers.discord.notifications.discord.DiscordNotifier

amoghrajesh commented 2 weeks ago

Tested my changes: https://github.com/apache/airflow/pull/41783, https://github.com/apache/airflow/pull/41680, https://github.com/apache/airflow/pull/41694 with breeze and all of them work as expected.

amoghrajesh commented 2 weeks ago

Also tested https://github.com/apache/airflow/pull/41890, for which I am the original contributor. I think we should cherry pick to retain the original author because the committer who cherry picks might not be fully aware of the scope of the change and shouldn't be responsible for testing it.

potiuk commented 2 weeks ago

Adding tojson filter to example_inlet_event_extra example dag (#41873) (#41890)

I think that needs some tooling improvement when generating the issue. The commit itself retains the original author:

But cherry-picked PR does not (and it cannot, because you cannot make another person author of your PR). So when we generate the issue, we should read commit information and simply add all commit authors to the issue.

Created https://github.com/apache/airflow/issues/41969

potiuk commented 2 weeks ago

All good for my changes !

potiuk commented 2 weeks ago

One thing: @hadarsharon -> can you please check if your https://github.com/apache/airflow/issues/41891 is solved in RC1 ?

hadarsharon commented 2 weeks ago

Yes @potiuk I just checked and can confirm that #41891 is resolved in v2.10.1.rc1

Cheers

vatsrahul1001 commented 2 weeks ago

Noticed issue while using TriggerDagRunOperator

joaopamaral commented 2 weeks ago

Tested https://github.com/apache/airflow/pull/41809 with the following FAB version:

1.2.2: permissions are synced correctly with the old access control format.
1.3.0: permissions are synced correctly with new and old access control formats.

So all good for this change.