Open kostiantyn-lab opened 5 days ago
Maybe you would like to fix it and contribute PR @kostiantyn-lab ? If not then I marked it as a good first issue and it will wait for someon who would like to fix it.
@potiuk I would like work on this, if that's okay.
@potiuk I would like work on this, if that's okay.
Feel free.
@potiuk I would like work on this, if that's okay.
it looks like we need to change this condition to something like this
before
if "bucket_name" not in bound_args.arguments:
after
# check that bucket_name is passed to parameters and does not have NULL or empty value
if not bound_args.arguments.get("bucket_name"):
just make a PR - discussing it on the changed code is so much easier.
@potiuk I would like work on this, if that's okay.
it looks like we need to change this condition to something like this
before
if "bucket_name" not in bound_args.arguments:
after
# check that bucket_name is passed to parameters and does not have NULL or empty value if not bound_args.arguments.get("bucket_name"):
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
Generally - look at the other, realated unit test cases. Use them as learning examples. Adding unit tests as part of the fix is "integral" part of code change.
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
You can use this test as an example. https://github.com/apache/airflow/blob/main/providers/tests/amazon/aws/hooks/test_s3.py#L1143
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
Generally - look at the other, realated unit test cases. Use them as learning examples. Adding unit tests as part of the fix is "integral" part of code change.
Plz review and merge my code I had also added unit test cases. @potiuk
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
Generally - look at the other, realated unit test cases. Use them as learning examples. Adding unit tests as part of the fix is "integral" part of code change.
Plz review and merge my code I had also added unit test cases. @potiuk
Once you fix failing test cases, sure. Also if you want to get review, ping in general "can you please review" in the PR or ask for review in #new-contributors slack channel. There are many reviewers here who can review and approve your code. It does not have to be me.
Can you help me in Creating the Unit Test Case, I had already Modified the Code ...
Generally - look at the other, realated unit test cases. Use them as learning examples. Adding unit tests as part of the fix is "integral" part of code change.
Plz review and merge my code I had also added unit test cases. @potiuk
Once you fix failing test cases, sure. Also if you want to get review, ping in general "can you please review" in the PR or ask for review in #new-contributors slack channel. There are many reviewers here who can review and approve your code. It does not have to be me.
You have already Reviewed and approved my code when will the PR be merged actually its my first PR....
You have already Reviewed and approved my code when will the PR be merged actually its my first PR....
The tests need to pass. As a first time contributor - someone needs to approve your "CI" workflows - that's why pinging it in your PR is the best way to drag attention to it. Simply "please approve and run my workflow here" in the PR will do. And again - any one of maintainers can do it - it does not have to be me. I might be on holidays, have vacations or simply be busy with 100 other prs :)
And it will be merged when it gets green - then you can also write "Hey my PR is green, can it be merged" - either in PR or in slack - with link to your PR. Doing it in PR makes it ... easier than an issue - because in here you might not easily see which PR you are asking for - you need to scroll the conversation all the way up and see "may be fixed by ...." so pinging in the PR is just ... more efficient.
Apache Airflow version
Other Airflow 2 version (please specify below)
If "Other Airflow 2 version" selected, which one?
2.10.1
What happened?
When using the HttpToS3Operator operator without s3_bucket parameter, I get this error:
What you think should happen instead?
the operator worked without errors, since S3Hook gets the S3 bucket name from the service_config in the extra connection information
How to reproduce
Create and run this simple DAG
Operating System
Amazon Linux 2023.5.20240916
Versions of Apache Airflow Providers
Deployment
Amazon (AWS) MWAA
Deployment details
No response
Anything else?
No response
Are you willing to submit PR?
Code of Conduct