apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
37.02k stars 14.27k forks source link

Incorrect FutureWarning possibly caused by a missing PR in 2.10.3 #43794

Open zachliu opened 4 hours ago

zachliu commented 4 hours ago

Apache Airflow version

2.10.3

If "Other Airflow 2 version" selected, which one?

No response

What happened?

In Airflow 2.10.3 configuration.py file, we have

https://github.com/apache/airflow/blob/c99887ec11ce3e1a43f2794fcf36d27555140f00/airflow/configuration.py#L857-L859

The self.sensitive_config_values returns both ('database', 'sql_alchemy_conn') and ('core', 'sql_alchemy_conn') because in 2.10.3 the deprecated_options variable is not empty. I think it's supposed to be removed. See https://github.com/apache/airflow/pull/42126.

Hence the self.get() raises a warning:

airflow/configuration.py:859 FutureWarning: section/key [core/sql_alchemy_conn] has been deprecated, you should use[database/sql_alchemy_conn] instead. Please update your `conf.get*` call to use the new name

Which confuses our users.

What you think should happen instead?

The warning should not be raised.

How to reproduce

  1. pip Install Airflow 2.10.3
  2. Run cli $ airflow version

Operating System

Debian GNU/Linux 10 (buster)

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

Code of Conduct

amoghrajesh commented 4 hours ago

@dirrao was this targetted for 2.10.3?