search

apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
37.26k stars 14.33k forks source link

Migrate public endpoint Patch Task Instance to FastAPI #44223

Open omkar-foss opened 1 day ago

omkar-foss commented 1 day ago

closes: https://github.com/apache/airflow/issues/43753, https://github.com/apache/airflow/issues/43754 and https://github.com/apache/airflow/issues/43752 related: https://github.com/apache/airflow/issues/42370

This migrates the Patch Task Instance API from api_connexion to api_fastapi.

omkar-foss commented 1 day ago

All checks passed, PR is ready for review ✅

omkar-foss commented 1 day ago

@pierrejeambrun I'm adding the Set Task Instance Note functionality to this (Patch Task Instance) API as you mentioned here. Will update this PR in a while.

omkar-foss commented 14 hours ago

I think we need to include the update_mask as we do for other patch endpoints. (The state part would actually be the set_task_instance_state of your other PR)

@pierrejeambrun I've added update_mask here in this PR to Patch Task Instance API.

Yes got it, sure, I've closed the other Set Task Instance State PR https://github.com/apache/airflow/pull/44246.