search

apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
37.26k stars 14.33k forks source link

Fixing static check due to faulty entry in openapi spec #44233

Closed amoghrajesh closed 19 hours ago

amoghrajesh commented 1 day ago

Fixing CI failure on https://github.com/apache/airflow/actions/runs/11945173632/job/33297606334.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

amoghrajesh commented 1 day ago

Looks like the original one is the correct one

bbovenzi commented 20 hours ago

These are autogenerated files. Is this a manual change or is it fixing an accidental manual change?

gopidesupavan commented 20 hours ago

Hope this change is not required, it looks like the side effect of pydantic version issue?

This is fine now, https://github.com/apache/airflow/pull/44249

pierrejeambrun commented 20 hours ago

Hope this change is not required, it looks like the side effect of pydantic version issue?

I think too. Can we close this one in favor of https://github.com/apache/airflow/pull/44249 ?

amoghrajesh commented 19 hours ago

Yep it is due to the underlying pydantic bug fixed by https://github.com/apache/airflow/pull/44249. Closing this one