apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
37.26k stars 14.33k forks source link

Allow `json_result_force_utf8_encoding` specification in `providers.snowflake.hooks.SnowflakeHook` extra dict #44264

Open ttzhou opened 17 hours ago

ttzhou commented 17 hours ago

Motivation/Justification:

Snowflake's Python connector recommends using json_result_force_utf8_decoding to True, but preserves it as False/no-op for legacy reasons. I've come across cases at work where not setting this returns unexpected results, whereas setting it to True (via a workaround) returns the expected results.

Therefore, I think there is a valid case for allowing this to be passed via connection arguments (via extra).

Relevant 'upstream' Snowflake connector code


boring-cyborg[bot] commented 17 hours ago

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: