search

apache / airflow

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows
https://airflow.apache.org/
Apache License 2.0
36.03k stars 13.99k forks source link

Replace azure-cosmos by azure-mgmt-cosmosdb #9742

Open feluelle opened 4 years ago

feluelle commented 4 years ago

Description

This should be a change which not effects the usage of the related provider modules i.e. refactoring.

Microsoft actively develops python packages for Azure in https://github.com/Azure/azure-sdk-for-python

This repository is for active development of the Azure SDK for Python

Those packages can be recognized by prefix azure-mgmt-.

morrme commented 4 years ago

Can share more about which tasks are required to complete this request?

feluelle commented 4 years ago

Thank you for your interest @morrme I will try to expand the description and what to do to solve this issue. 😊

feluelle commented 4 years ago

Hey @morrme sorry I want to get https://github.com/apache/airflow/pull/9747 in before we can start with this, because I would like to reuse the authentication mechanism there.

I am gonna add more information about what we need to change to solve this ticket. :)

I would probably then simply start with replacing the dependency and then fix the AzureCosmosDBHook which is the interface for all operators that want to communicate to cosmos db. Since we have unittests for this hook we can change all calls from the previous api/dependency to the new one.

Of course we should system test this changed AzureCosmosDBHook as well.

So if I understand you correctly, you want to solve this ticket/issue? - then I am assigning it to you if that's okay?! :) Do you also have an account to system test it?

feluelle commented 4 years ago

I would be happy to support you during this. If you want to reach out to me I am on slack, too (feluelle).

morrme commented 4 years ago

@feluelle I appreciate it, but I do not have an account, so I don't think I'm able to help. I saw that there were a few of these but not sure what was required to assist.

feluelle commented 4 years ago

@morrme no problem. We can find something different you can work on. If you want we can chat via slack to find something you would like to work on i.e. improve, fix or a feature you would like to see in airflow. WDYT? :)

If yes, just pm me in slack "feluelle".