search

apache / apisix-docker

the docker for Apache APISIX
https://apisix.apache.org/
Apache License 2.0
718 stars 449 forks source link

Example containers using old images #417

Open allentc opened 1 year ago

allentc commented 1 year ago

Some of the images that appear in example/docker-compose.yml are very old. Example:

I'd offer a pull request to update images but I haven't found any compatibility matrix or other information on what has been qualified for use with APISIX.

Neilblaze commented 1 year ago

@navendu-pottekkat can you have a look at this please? I'm also curious whether we have a set of updated images for the same which will be potentially used as a replacement?

pottekkat commented 1 year ago

@Neilblaze Thank you for the ping. @allentc Thank you for opening this issue.

@Neilblaze yes, these could be updated. I think we can use the latest LTS versions of each of the images. Prior to making a pull request, please test and check if everything is working as intended.

We can use the existing images but bump the version. I don't there would be anything else to change but look out for compatibility issues.

juzhiyuan commented 1 year ago

Prometheus & Grafana are for the all-in-one case, +1 to upgrade them, but do we really need a all-in-one sample docker compose?

soulbird commented 1 year ago

I don't think all-in-one has any effect, we can consider deleting it

Neilblaze commented 1 year ago

I'm a bit confused about whether to remove Prometheus and other images entirely from the compose file. Would you mind sharing some light on this? And else, if I want to upgrade them in general, where can I get the latest images that would be used as potential replacement?

cc: @juzhiyuan , @soulbird

juzhiyuan commented 1 year ago

, if I want to upgrade them in general, where can I get the latest images that would be used as potential replacement?

To confirm: "them" - do you mean Prometheus, APISIX, and other components?

For this issue, welcome to file a PR to upgrade them.

pottekkat commented 1 year ago

@Neilblaze You can use the later versions of the same images from Docker Hub.

Bloodraven21 commented 2 months ago

Hey @pottekkat can you assign this issue to me and let me upgrade examples to the latest lts

pottekkat commented 2 months ago

Sure @Bloodraven21 . Assigned.

Bloodraven21 commented 2 months ago

i have created a pr