search

apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX
https://apisix.apache.org/
Apache License 2.0
167 stars 69 forks source link

fix: set the correct rpc response type when meet an error #102

Closed MrLYC closed 1 year ago

MrLYC commented 1 year ago

Go runner always return the request rpc type as response type, according to the protocol, it should return RPCError when meet an error.

soulbird commented 1 year ago

Let's merge the master branch to run E2E Test.

codecov-commenter commented 1 year ago

Codecov Report

Merging #102 (71906e7) into master (bd5d11f) will decrease coverage by 1.74%. The diff coverage is 27.77%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   82.38%   80.64%   -1.75%     
==========================================
  Files          14       14              
  Lines         897      899       +2     
==========================================
- Hits          739      725      -14     
- Misses        113      132      +19     
+ Partials       45       42       -3
Impacted Files Coverage Δ
internal/server/server.go 53.90% <27.77%> (-11.97%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more