apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX
https://apisix.apache.org/
Apache License 2.0
167 stars 69 forks source link

feat: support request body rewrite #127 #151

Closed TomCN0803 closed 7 months ago

TomCN0803 commented 7 months ago

Features and modifications includes:

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f049304) 80.75% compared to head (b5bf984) 80.37%.

:exclamation: Current head b5bf984 differs from pull request most recent head f23ac95. Consider uploading reports for the commit f23ac95 to get more accurate results

Files Patch % Lines
cmd/go-runner/plugins/request_body_rewrite.go 75.00% 2 Missing and 2 partials :warning:
internal/http/request.go 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ========================================== - Coverage 80.75% 80.37% -0.38% ========================================== Files 16 17 +1 Lines 1034 1060 +26 ========================================== + Hits 835 852 +17 - Misses 146 156 +10 + Partials 53 52 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

monkeyDluffy6017 commented 7 months ago

Nice work!

monkeyDluffy6017 commented 7 months ago

@bzp2010 please help to review

soulbird commented 7 months ago

Whether content-length needs to be processed?

TomCN0803 commented 7 months ago

Whether content-length needs to be processed?

@soulbird Is it a must to make limitations here? Flatbuffer itself has size limit of 2GB (https://stackoverflow.com/questions/59185516/do-flatbuffers-have-size-limits).