bug: there is a typo while populating GITSHA - Githubissues

apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX

https://apisix.apache.org/

Apache License 2.0

169 stars 69 forks source link

bug: there is a typo while populating GITSHA #57

Closed ms2008 closed 2 years ago

ms2008 commented 2 years ago

Issue description

There is a typo in this place:

https://github.com/apache/apisix-go-plugin-runner/blob/0cfd47b75a403215e78f78bf468dc4e87f8a6ecf/Makefile#L22

The pipeline here should be logical or operational, which is a double pipe symbol as ||.

Environment

APISIX Go Plugin Runner's version:
APISIX version:
Go version:
OS (cmd: uname -a):

Minimal test code / Steps to reproduce the issue

1. 2. 3.

What's the actual result? (including assertion message & call stack if applicable)

Version: latest
Git SHA: 
Go Version: go1.17.5
Building OS/Arch: linux/amd64
Running OS/Arch: linux/amd64

What's the expected result?

Version: latest
Git SHA: 0cfd47b
Go Version: go1.17.5
Building OS/Arch: linux/amd64
Running OS/Arch: linux/amd64

spacewander commented 2 years ago

Good catch. PR is welcome!