Closed Belyenochi closed 2 years ago
Merging #63 (fed69d0) into master (6bb1c4b) will increase coverage by
3.09%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 77.74% 80.84% +3.09%
==========================================
Files 11 11
Lines 701 710 +9
==========================================
+ Hits 545 574 +29
+ Misses 119 100 -19
+ Partials 37 36 -1
Impacted Files | Coverage Δ | |
---|---|---|
internal/http/request.go | 94.28% <88.88%> (-0.25%) |
:arrow_down: |
internal/http/response.go | 100.00% <0.00%> (ø) |
|
internal/server/server.go | 67.47% <0.00%> (+17.07%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6bb1c4b...fed69d0. Read the comment docs.
Don't forget to add a test to cover it.
Yes, I added a simple Context unit test, please feel free to drop me a message if you have good optimization suggestions, thanks
Need to set the
ctx
to nil in
Thanks for the code review, done fixed
approve running workflows.
pls approve running workflows.
Need to set the
ctx
to nil in
pls help to approve again
hi @spacewander, pls help to approve running workflows
Merged. Thanks!
Resolves issues 34