search

apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX
https://apisix.apache.org/
Apache License 2.0
167 stars 69 forks source link

feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation #68

Closed rampagecong closed 2 years ago

rampagecong commented 2 years ago

This submission is modified as follows:

1.Add respHdr and RespHeader method to Request struct.

2.The Request FetchChanges method is modified.

3.Add and modify some test cases

This is refer to https://github.com/apache/apisix-go-plugin-runner/issues/67

spacewander commented 2 years ago

Sorry for my delay. Could you make the CI pass?

rampagecong commented 2 years ago

OK

spacewander commented 2 years ago

Need to resolve conflicts

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (24381ca) into master (ade2e90) will decrease coverage by 2.19%. The diff coverage is 96.15%.

:exclamation: Current head 24381ca differs from pull request most recent head 95a790f. Consider uploading reports for the commit 95a790f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   80.60%   78.41%   -2.20%     
==========================================
  Files          11       11              
  Lines         722      746      +24     
==========================================
+ Hits          582      585       +3     
- Misses        102      122      +20     
- Partials       38       39       +1
Impacted Files Coverage Δ
internal/http/request.go 93.49% <96.15%> (+0.70%) :arrow_up:
internal/server/server.go 50.40% <0.00%> (-17.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ade2e90...95a790f. Read the comment docs.

rampagecong commented 2 years ago

Hello,Please run CI again. @spacewander