search

apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX
https://apisix.apache.org/
Apache License 2.0
167 stars 69 forks source link

feat: improve e2e test environment #82

Closed Chever-John closed 1 year ago

Chever-John commented 2 years ago

This PR aims to solve the problem submitted by #81

  1. Let APISIX manage the go-runner in the e2e test runtime, just like the production environment;
  2. Remove unused HTTPS port.
codecov-commenter commented 2 years ago

Codecov Report

Merging #82 (cf1eea5) into master (160e058) will decrease coverage by 1.74%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   81.23%   79.49%   -1.75%     
==========================================
  Files          11       11              
  Lines         746      746              
==========================================
- Hits          606      593      -13     
- Misses        102      114      +12     
- Partials       38       39       +1
Impacted Files Coverage Δ
internal/server/server.go 56.91% <0.00%> (-10.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 160e058...cf1eea5. Read the comment docs.

spacewander commented 2 years ago

Please make the CI pass, thanks!

Chever-John commented 2 years ago

Please make the CI pass, thanks!

I am trying~

soulbird commented 1 year ago

@Chever-John Do you still have time to complete this PR?

Chever-John commented 1 year ago

@soulbird I think this PR will not make sense now. It had been a long time. I will close this PR.

soulbird commented 1 year ago

@soulbird I think this PR will not make sense now. It had been a long time. I will close this PR.

ok